Page 2 of 2

Re: First Entry into Matrix Pushes Stack

Posted: Sat Mar 10, 2018 8:09 pm
by Thomas Okken
The stack-lift-preservation behavior actually happens in EDIT and EDITN -- easy to overlook if you keep setting up your test case like 2 ENTER ENTER ENTER EDITN "M". So, still weird behavior, but at least a bit more consistent than I thought.
Release 2.0.19 coming up...

Re: First Entry into Matrix Pushes Stack

Posted: Sun Mar 11, 2018 5:44 am
by Epidiah
This is probably as it should be, then, but in case it matters, the stack lifts for the first entries into MATA, MATB, and MATX as well.

Re: First Entry into Matrix Pushes Stack

Posted: Sun Mar 11, 2018 11:29 am
by whuyse
Thomas Okken wrote:
Sat Mar 10, 2018 4:37 pm
Update: no, wait, it's even weirder. EDIT preserves the existing stack lift status. Hmm, and that's exactly what my old code did.
No, not quite.
With v2.0.17

Code: Select all

2
ENTER
ENTER
ENTER
NEWMAT
ENTER
EDIT
42
RDN
Gives 0 on Free42 and the matrix on a 42S
Cheers, Werner

Re: First Entry into Matrix Pushes Stack

Posted: Sun Mar 11, 2018 11:50 am
by Thomas Okken
I stand corrected! This is an aspect of the matrix editor that was clearly not as well thought out and tested against the original as it should have been. But I think in 2.0.19 I finally got it right...

Well, except for MATA, MATB, and MATX in the SIMQ menu, which activate the matrix editor and exhibit the same stack lift behavior as EDIT and EDITN on the HP-42S, and not (yet) in Free42, as Epidiah pointed out.

So, the same patch will have to be applied there. It's not as important as the EDIT/EDITN fix, because MATA, MATB, and MATX are not programmable, but they should be fixed anyway for the sake of consistency.

Re: First Entry into Matrix Pushes Stack

Posted: Tue Mar 13, 2018 3:41 am
by Thomas Okken
Thomas Okken wrote:
Sun Mar 11, 2018 11:50 am
I stand corrected! This is an aspect of the matrix editor that was clearly not as well thought out and tested against the original as it should have been. But I think in 2.0.19 I finally got it right...

Well, except for MATA, MATB, and MATX in the SIMQ menu, which activate the matrix editor and exhibit the same stack lift behavior as EDIT and EDITN on the HP-42S, and not (yet) in Free42, as Epidiah pointed out.

So, the same patch will have to be applied there. It's not as important as the EDIT/EDITN fix, because MATA, MATB, and MATX are not programmable, but they should be fixed anyway for the sake of consistency.
Fixed in 2.0.20.